Skip to content

[HUD][TTS] Add granularity, time, etc to permalink #6989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Aug 8, 2025

Fixes #6939

Add time range, granularity, percentile to permalink (previously only had job names)

Also fixes percentile picker to use value instead of default value so the values from the router will be used?

Should have no visual changes

Is there a better way to do retrieve the router info? This seems really annoying

Copy link

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Aug 8, 2025 9:47pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
@clee2000 clee2000 marked this pull request as ready for review August 8, 2025 21:48
@clee2000 clee2000 requested a review from a team August 8, 2025 21:49
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clee2000 clee2000 merged commit ec0c0ce into main Aug 12, 2025
5 checks passed
@clee2000 clee2000 deleted the csl/tts_fix_permalink branch August 12, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job TTS and Duration permalink doesn't capture all dropdown values
2 participants